Expose ImmutableProvider and ImmutableProviderTree #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 12 +3
Lines 181 188 +7
=====================================
+ Hits 181 188 +7
Continue to review full report at Codecov.
|
felangel
force-pushed
the
feature/immutable-provider
branch
2 times, most recently
from
54d4959
to
70611f2
Compare
felangel
force-pushed
the
feature/immutable-provider
branch
from
70611f2
to
5e4e947
Compare
jorgecoca
approved these changes
Jun 21, 2019
| if (provider == null) { | ||
| throw FlutterError( | ||
| """ | ||
| ImmutableProvider.of() called with a context that does not contain a value of type $T. |
There was a problem hiding this comment.
Good job on this error message. This will help a lot to troubleshoot issues ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Allow developers to provide immutable values, such as repositories, throughout the widget tree (#354).
Expose
ImmutableProviderImmutableProviderTreeRefactor
BlocProviderBlocProviderTreeBlocListenerBlocListenerTreeTodos
Impact to Remaining Code Base
None