Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix BlocProvider copyWith() #377

Merged
merged 1 commit into from
Jun 26, 2019
Merged

fix BlocProvider copyWith() #377

merged 1 commit into from
Jun 26, 2019

Conversation

anatter
Copy link
Contributor

@anatter anatter commented Jun 25, 2019 •
edited by felangel
Loading

Status

READY

Breaking Changes

NO

Description

Impact to Remaining Code Base

None

@anatter anatter requested a review from felangel as a code owner June 25, 2019 12:06
@anatter anatter mentioned this pull request Jun 25, 2019
Closed
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #377 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #377   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         188    189    +1     
=====================================
+ Hits          188    189    +1
Impacted Files Coverage Δ
packages/flutter_bloc/lib/src/bloc_provider.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fcfa0...4cfc66f. Read the comment docs.

@felangel felangel added the bug Something isn't working label Jun 25, 2019
@felangel felangel added this to In progress in bloc Jun 25, 2019
felangel
felangel approved these changes Jun 26, 2019
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution 💯

@felangel felangel merged commit d9c31e0 into felangel:master Jun 26, 2019
@felangel felangel moved this from In progress to Done in bloc Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@anatter anatter

Labels
bug Something isn't working
Projects
bloc
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anatter @felangel