Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bloc_test): test timeouts due to uncaught exceptions #3854

Merged
merged 4 commits into from May 31, 2023

Conversation

felangel
Copy link
Owner

Status

HOLD

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added bug Something isn't working pkg:bloc_test This issue is related to the bloc_test package labels May 27, 2023
@felangel felangel self-assigned this May 27, 2023
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (672a2c6) 100.00% compared to head (9f1b7b1) 100.00%.

❗ Current head 9f1b7b1 differs from pull request most recent head b1503fb. Consider uploading reports for the commit b1503fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #3854    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           31         3    -28     
  Lines          746        82   -664     
==========================================
- Hits           746        82   -664     
Impacted Files Coverage Δ
packages/bloc_test/lib/src/bloc_test.dart 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felangel felangel merged commit f609a40 into master May 31, 2023
24 checks passed
@felangel felangel deleted the fix/bloc-test-timeouts branch May 31, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:bloc_test This issue is related to the bloc_test package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: blocTest hangs on unhandled exceptions from flutter 3.10
2 participants