Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.0 #700

Merged
merged 29 commits into from
Dec 25, 2019
Merged

v3.0.0 #700

merged 29 commits into from
Dec 25, 2019

Conversation

felangel
Copy link
Owner

@felangel felangel commented Nov 27, 2019 •
edited
Loading

Status

READY

Breaking Changes

YES

Description

Todos

  • bloc
    • Tests
    • Documentation
    • Examples
  • bloc_test
    • Tests
    • Documentation
    • Examples
  • angular_bloc
    • Tests
    • Documentation
    • Examples
  • flutter_bloc
    • Tests
    • Documentation
    • Examples

Impact to Remaining Code Base

  • Breaking changes introduced in v3.0.0 of bloc
  • Will require major version bumps in bloc_test, flutter_bloc, angular_bloc, hydrated_bloc, and sealed_flutter_bloc.

@felangel felangel added enhancement New feature or request pkg:bloc This issue is related to the bloc package labels Nov 27, 2019
@felangel felangel self-assigned this Nov 27, 2019
@felangel felangel added this to In progress in bloc via automation Nov 27, 2019
@felangel felangel added this to the v3.0.0 milestone Nov 27, 2019
@felangel felangel force-pushed the bloc/v3.0.0 branch 2 times, most recently from 17db7dc to 2ee8cea Compare November 27, 2019 23:05
@codecov
Copy link

codecov bot commented Nov 27, 2019 •
edited
Loading

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #700   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         236    221   -15     
=====================================
- Hits          236    221   -15
Impacted Files Coverage Δ
...ages/flutter_bloc/lib/src/repository_provider.dart 100% <ø> (ø) ⬆️
packages/bloc/lib/src/bloc.dart 100% <ø> (ø) ⬆️
packages/flutter_bloc/lib/src/bloc_builder.dart 100% <100%> (ø) ⬆️
packages/flutter_bloc/lib/src/bloc_provider.dart 100% <100%> (ø) ⬆️
packages/flutter_bloc/lib/src/bloc_listener.dart 100% <100%> (ø) ⬆️
packages/bloc/lib/src/bloc_supervisor.dart 100% <0%> (ø) ⬆️
packages/bloc/lib/src/bloc_delegate.dart 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e79034...e868d4e. Read the comment docs.

@felangel
Copy link
Owner Author

@brianegan mind taking a look?

@felangel felangel force-pushed the bloc/v3.0.0 branch 2 times, most recently from 901dbc8 to 7c5b157 Compare November 27, 2019 23:36
brianegan
brianegan previously approved these changes Nov 28, 2019
View reviewed changes
Copy link

@brianegan brianegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

jorgecoca
jorgecoca previously approved these changes Nov 28, 2019
View reviewed changes
packages/bloc/CHANGELOG.md
@@ -1,3 +1,7 @@
# 3.0.0-dev.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@felangel felangel dismissed stale reviews from jorgecoca and brianegan via 8d03749 November 28, 2019 06:24
@felangel felangel changed the title Update to rxdart ^0.23.0-dev.2 Update to rxdart ^0.23.0 Nov 28, 2019
@felangel felangel changed the title Update to rxdart ^0.23.0 v3.0.0 Nov 28, 2019
@felangel felangel added pkg:flutter_bloc This issue is related to the flutter_bloc package pkg:angular_bloc This issue is related to the angular_bloc package pkg:bloc_test This issue is related to the bloc_test package labels Nov 29, 2019
@felangel felangel force-pushed the bloc/v3.0.0 branch 7 times, most recently from b8aa760 to 7d82cdc Compare December 1, 2019 06:09
@felangel felangel force-pushed the bloc/v3.0.0 branch 2 times, most recently from 68bec10 to 588bf0f Compare December 25, 2019 05:54
@felangel felangel merged commit a0f1e7f into master Dec 25, 2019
bloc automation moved this from In progress to Done Dec 25, 2019
@felangel felangel deleted the bloc/v3.0.0 branch December 25, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenhobi tenhobi tenhobi left review comments

@lsaudon lsaudon lsaudon left review comments

@brianegan brianegan brianegan left review comments

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@felangel felangel

Labels
dependency This issue has an external dependency enhancement New feature or request pkg:angular_bloc This issue is related to the angular_bloc package pkg:bloc_test This issue is related to the bloc_test package pkg:bloc This issue is related to the bloc package pkg:flutter_bloc This issue is related to the flutter_bloc package
Projects
bloc
  
Done
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@felangel @warriorCoder @brianegan @jorgecoca @tenhobi @lsaudon