Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.0 #700

Merged
merged 29 commits into from Dec 25, 2019
Merged

v3.0.0 #700

merged 29 commits into from Dec 25, 2019

Conversation

@felangel
Copy link
Owner

felangel commented Nov 27, 2019

Status

READY

Breaking Changes

YES

Description

  • Upgrade to bloc to use rxdart ^0.23.0 which introduces support for extensions and unifies Streams and Observables
  • Upgrade to Dart >=2.6.0
  • Upgrade flutter_bloc to use provider ^4.0.0
  • Revert flutter_bloc condition to previous behavior (#709)

Todos

  • bloc
    • Tests
    • Documentation
    • Examples
  • bloc_test
    • Tests
    • Documentation
    • Examples
  • angular_bloc
    • Tests
    • Documentation
    • Examples
  • flutter_bloc
    • Tests
    • Documentation
    • Examples

Impact to Remaining Code Base

  • Breaking changes introduced in v3.0.0 of bloc
  • Will require major version bumps in bloc_test, flutter_bloc, angular_bloc, hydrated_bloc, and sealed_flutter_bloc.
@felangel felangel self-assigned this Nov 27, 2019
@felangel felangel added this to In progress in bloc via automation Nov 27, 2019
@felangel felangel force-pushed the bloc/v3.0.0 branch from 3737014 to 848223c Nov 27, 2019
@felangel felangel added this to the v3.0.0 milestone Nov 27, 2019
@felangel felangel force-pushed the bloc/v3.0.0 branch 2 times, most recently from 17db7dc to 2ee8cea Nov 27, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #700   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         236    221   -15     
=====================================
- Hits          236    221   -15
Impacted Files Coverage Δ
...ages/flutter_bloc/lib/src/repository_provider.dart 100% <ø> (ø) ⬆️
packages/bloc/lib/src/bloc.dart 100% <ø> (ø) ⬆️
packages/flutter_bloc/lib/src/bloc_builder.dart 100% <100%> (ø) ⬆️
packages/flutter_bloc/lib/src/bloc_provider.dart 100% <100%> (ø) ⬆️
packages/flutter_bloc/lib/src/bloc_listener.dart 100% <100%> (ø) ⬆️
packages/bloc/lib/src/bloc_supervisor.dart 100% <0%> (ø) ⬆️
packages/bloc/lib/src/bloc_delegate.dart 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e79034...e868d4e. Read the comment docs.

@felangel felangel requested a review from jorgecoca Nov 27, 2019
@felangel

This comment has been minimized.

Copy link
Owner Author

felangel commented Nov 27, 2019

@brianegan mind taking a look?

@felangel felangel force-pushed the bloc/v3.0.0 branch 2 times, most recently from 901dbc8 to 7c5b157 Nov 27, 2019
Copy link

brianegan left a comment

Looking good so far!

@@ -1,3 +1,7 @@
# 3.0.0-dev.1

This comment has been minimized.

Copy link
@jorgecoca

jorgecoca Nov 28, 2019

Collaborator

💯

@felangel felangel dismissed stale reviews from jorgecoca and brianegan via 8d03749 Nov 28, 2019
@felangel felangel requested a review from jorgecoca Nov 28, 2019
@felangel felangel changed the title Update to rxdart ^0.23.0-dev.2 Update to rxdart ^0.23.0 Nov 28, 2019
@felangel felangel changed the title Update to rxdart ^0.23.0 v3.0.0 Nov 28, 2019
@felangel felangel force-pushed the bloc/v3.0.0 branch 7 times, most recently from b8aa760 to 7d82cdc Dec 1, 2019
@felangel felangel force-pushed the bloc/v3.0.0 branch from 30d47c4 to 07fd75b Dec 23, 2019
@felangel felangel force-pushed the bloc/v3.0.0 branch 2 times, most recently from 68bec10 to 588bf0f Dec 25, 2019
@felangel felangel force-pushed the bloc/v3.0.0 branch from 588bf0f to 08c2a37 Dec 25, 2019
@felangel felangel merged commit a0f1e7f into master Dec 25, 2019
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 4e79034
Details
bloc automation moved this from In progress to Done Dec 25, 2019
@felangel felangel deleted the bloc/v3.0.0 branch Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
bloc
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.