-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RxDart dependency from bloc package #821
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7d6df6b
Removed Rx dependency from bloc package
mozhaiskyi 78de7e3
Removed unnecessary broadcast stream
mozhaiskyi f92d137
Merge branch 'master' into remove-rx-dependency
mozhaiskyi 0af3a9d
Implemented StateSubject
mozhaiskyi 8d31770
Merge branch 'master' into remove-rx-dependency
mozhaiskyi f5c4992
Merge branch 'master' into remove-rx-dependency
mozhaiskyi 8086522
Simplified StateSubject solution
mozhaiskyi 8eadc3b
_eventsController marked as broadcast
mozhaiskyi 5275a30
Implemented async* approach
mozhaiskyi 8bd3dd4
Update packages/bloc/lib/src/bloc.dart
mozhaiskyi 69e74e4
Renamed to _state
mozhaiskyi af73012
Small refactoring
mozhaiskyi 67f8afe
Renamed to _bindEventsToStates
mozhaiskyi e22fe81
Removed unnecessary .sink call
mozhaiskyi a2fca17
Fixed multi listeners problem
mozhaiskyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd just make sure to add the test to catch this bug as well.