Decouple Bloc from RxDart #838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
added
enhancement candidate
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 12 -4
Lines 247 209 -38
=====================================
- Hits 247 209 -38Continue to review full report at Codecov.
|
felangel
force-pushed
the
remove-rxdart
branch
4 times, most recently
from
2b5e9fa
to
c349b76
Compare
felangel
force-pushed
the
remove-rxdart
branch
from
c349b76
to
a8e54d2
Compare
|
@brianegan when you have a min can you take a look? |
felangel
force-pushed
the
remove-rxdart
branch
from
a8e54d2
to
6b9b2e1
Compare
mozhaiskyi
reviewed
Feb 2, 2020
felangel
force-pushed
the
remove-rxdart
branch
3 times, most recently
from
3267a5a
to
c908edf
Compare
felangel
force-pushed
the
remove-rxdart
branch
from
c908edf
to
533fb8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
IN DEVELOPMENT
Breaking Changes
YES
Description
rxdartas a dependency frombloc(related to Remove RxDart dependency from bloc package #821)_TransitionStreamTransformerobject which encapsulates the current transition in order to ensure that transitions occur for the respective event/state pair.(Remove RxDart dependency #839 (comment))transformStatestotransformTransitionstransformEventssignature change to take aTransitionFunctionTodos
Impact to Remaining Code Base
transformStates->transformTransitionstransformEvents