Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic names gets lost in the Kafka input connector configuration dialogue #594

Closed
ryzhyk opened this issue Aug 28, 2023 · 3 comments · Fixed by #599 or #607
Closed

Topic names gets lost in the Kafka input connector configuration dialogue #594

ryzhyk opened this issue Aug 28, 2023 · 3 comments · Fixed by #599 or #607
Assignees
Labels
Web Console Related to the browser based UI

Comments

@ryzhyk
Copy link
Contributor

ryzhyk commented Aug 28, 2023

If the user doesn't press Enter after typing the topic name (which most users won't, because this is not at all obvious), it gets lost and the generated connector has an empty list of topics.

Additionally, the dialogue should enforce non-empty list of topics, otherwise the connector config is invalid.

@ryzhyk ryzhyk added the Web Console Related to the browser based UI label Aug 28, 2023
gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
@gz gz closed this as completed in #599 Aug 29, 2023
gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
@ryzhyk
Copy link
Contributor Author

ryzhyk commented Aug 29, 2023

Let's keep it open. This is still a ux issue, maybe one day we find a way to solve it.

@ryzhyk ryzhyk reopened this Aug 29, 2023
@gz
Copy link
Collaborator

gz commented Aug 29, 2023

The 'right' fix for this probably involves to get a list of topics from the backend/kafka host then make this a drop-down list where the user can select them.

gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
gz added a commit that referenced this issue Aug 29, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
@ryzhyk
Copy link
Contributor Author

ryzhyk commented Aug 29, 2023

The 'right' fix for this probably involves to get a list of topics from the backend/kafka host then make this a drop-down list where the user can select them.

This would be nice, but we can't always assume that the topic exists at connector creation time, so being able to enter it manually is still useful.

ryzhyk pushed a commit that referenced this issue Aug 30, 2023
Fixes #594.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Console Related to the browser based UI
Projects
None yet
3 participants