-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic names gets lost in the Kafka input connector configuration dialogue #594
Comments
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Let's keep it open. This is still a ux issue, maybe one day we find a way to solve it. |
The 'right' fix for this probably involves to get a list of topics from the backend/kafka host then make this a drop-down list where the user can select them. |
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
This would be nice, but we can't always assume that the topic exists at connector creation time, so being able to enter it manually is still useful. |
Fixes #594. Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
If the user doesn't press Enter after typing the topic name (which most users won't, because this is not at all obvious), it gets lost and the generated connector has an empty list of topics.
Additionally, the dialogue should enforce non-empty list of topics, otherwise the connector config is invalid.
The text was updated successfully, but these errors were encountered: