Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka output connector busy-waits in connect() #842

Closed
blp opened this issue Oct 5, 2023 · 1 comment · Fixed by #852
Closed

Kafka output connector busy-waits in connect() #842

blp opened this issue Oct 5, 2023 · 1 comment · Fixed by #852
Assignees
@ryzhyk
Labels
adapters Issues related to the adapters crate bug Something isn't working performance
Milestone
October 10, 2023

Comments

@blp
Copy link
Member

blp commented Oct 5, 2023

It looks to me like the loop in connect for KafkaOutputEndpoint is a busy-wait loop. I didn't test it, I just noticed this while reading code.
@blp blp added bug Something isn't working performance adapters Issues related to the adapters crate labels Oct 5, 2023
@ryzhyk
Copy link
Contributor

ryzhyk commented Oct 8, 2023

Yep, looks like I forgot to add a sleep() in that loop. Will fix it.

@ryzhyk ryzhyk self-assigned this Oct 8, 2023
@ryzhyk ryzhyk added this to the October 10, 2023 milestone Oct 8, 2023
ryzhyk pushed a commit that referenced this issue Oct 8, 2023
Fix busy-wait loop in Kafka producer.
d718286 
Fixes #842

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
ryzhyk pushed a commit that referenced this issue Oct 8, 2023
Fix busy-wait loop in Kafka producer.
a917e3a 
Fixes #842

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
@ryzhyk ryzhyk mentioned this issue Oct 8, 2023
Merged
ryzhyk pushed a commit that referenced this issue Oct 8, 2023
@ryzhyk
Fix busy-wait loop in Kafka producer.
28acc8b 
Fixes #842

Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryzhyk ryzhyk

Labels
adapters Issues related to the adapters crate bug Something isn't working performance
Projects
None yet
Milestone
October 10, 2023
Development

Successfully merging a pull request may close this issue.

Fix busy-wait loop in Kafka producer. feldera/feldera
2 participants
@blp @ryzhyk