pipeline-manager: add metrics to compiler server #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalithsuresh
force-pushed
the
metrics
branch
from
f7cd3d8
to
c87e8d6
Compare
gz
approved these changes
Nov 17, 2023
crates/pipeline_manager/Cargo.toml
Outdated
| @@ -51,6 +51,8 @@ refinery = {version = "0.8.10", features = ["tokio-postgres"]} | |||
| reqwest = {version = "0.11.18", features = ["json"]} | |||
| url = {version = "2.4.0"} | |||
| dirs = "5.0" | |||
| prometheus-client = "0.22.0" | |||
| lazy_static = "1.4.0" | |||
There was a problem hiding this comment.
check if can use std lib instead (see rust-lang-nursery/lazy-static.rs#214)
https://doc.rust-lang.org/nightly/std/sync/struct.OnceLock.html
https://doc.rust-lang.org/nightly/std/sync/struct.Once.html
| invocations: Family::<MetricLabel, Counter>::default(), | ||
| latency: Family::<MetricLabel, Histogram>::new_with_constructor(|| { | ||
| // These are buckets for measuring SQL and rust compilation times | ||
| let buckets = [1.0, 5.0, 10.0, 20.0, 50.0, 100.0, 200.0, 400.0]; |
There was a problem hiding this comment.
Histogram CDF points. So if compilation takes say, 15 seconds, it'll add 1 to buckets 20, 50, 100, 200 and 400.
I don't have a good sense for what the most useful CDF points should be yet, I hope to tweak them as we go.
There was a problem hiding this comment.
got it maybe this can be a comment :)
lalithsuresh
force-pushed
the
metrics
branch
from
c87e8d6
to
c06951b
Compare
Signed-off-by: Lalith Suresh <lalith@feldera.com>
lalithsuresh
force-pushed
the
metrics
branch
from
c06951b
to
5bee31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit starts adding metrics to the pipeline-manager components. We'll start with the compiler server for now. We'll expose histograms for compiler latencies as well as a counter for the number of invocations. These two metrics are faceted by two labels: the phase (SQL vs Rust) and the status (Success vs Error).
For now, we'll always host metrics via a scrape endpoint on a different port (0.0.0.0:9000/metrics) than the usual APIs (80/8080). This is to make sure that we can avoid exposing the scraping endpoint outside the docker ensemble or cluster in a real deployment.
Is this a user-visible change (yes/no): yes