[SQL] Add support for 'default' column values #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
changed the title
|
@mihaibudiu , do we need to impose any restrictions on default values to make sure they are deterministic, so that replaying the same Kafka messages results in the same values in input tables? |
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Optimize `deserialize_table_record` and `deserialize_struct` macros. Instead of assigning default values to fields before deserializing the struct, we deserialize first and only assign defaults to missing fields. Signed-off-by: Leonid Ryzhyk <leonid@feldera.com>
Right now we don't have support for any non deterministic function |
ryzhyk
approved these changes
Nov 25, 2023
ryzhyk
pushed a commit
that referenced
this pull request
Feb 20, 2024
* [SQL] Add parser support for 'default' column values * [SQL] Emit serde code for default values * Optimize the handling of defaults in deserialization. Optimize `deserialize_table_record` and `deserialize_struct` macros. Instead of assigning default values to fields before deserializing the struct, we deserialize first and only assign defaults to missing fields. Signed-off-by: Mihai Budiu <mbudiu@feldera.com> Co-authored-by: Leonid Ryzhyk <leonid@feldera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a user-visible change (yes/no): yes
Fixes #1058