[SQL] Add the mathematical constant PI #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhizer
added
documentation
|
You should add a Fixes: line to the comments so the corresponding issue is automatically closed. |
mihaibudiu
approved these changes
Dec 8, 2023
docs/sql/float.md
Outdated
| @@ -92,4 +92,8 @@ REAL '1.23' -- string style | |||
| <td><code>COS(value)</code></td> | |||
| <td>The cosine of value as radians. <code>cos</code> only supports argument of type double, so all other types are cast to double. Returns a double.</td> | |||
| </tr> | |||
| <tr> | |||
| <td><code>PI</code></td> | |||
| <td>Returns the approximate value of <code>PI</code> as double.</td> | |||
There was a problem hiding this comment.
You should add a note that no () is required.
| " sin \n" + | ||
| "-----\n" + | ||
| " 0.0015926529164868282\n" + | ||
| " 0\n" + // Postgres disagrees with us here, but currently we round off to 15 decimal places |
There was a problem hiding this comment.
I like this result better.
| @@ -86,10 +86,10 @@ public void testSinDouble() { | |||
| " 0.8414709848078965\n" + | |||
| "(1 row)\n" + | |||
| "\n" + | |||
| "SELECT sin(CAST(3.14 AS DOUBLE));\n" + | |||
| "SELECT sin(CAST(pi AS DOUBLE));\n" + | |||
There was a problem hiding this comment.
this one is probably not necessary since pi is already a double.
* Also updates the sin and cos tests to use PI instead of 3.14 Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
* Remove tests that cast PI to double as PI is already double * Mention that floats are rounded off to 6 and doubles 15 decimal places in the docs Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a user-visible change (yes/no): yes
Fixes: #1115