Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Inspect connector' button to the connector list in Pipeline Builder #1128

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

Karakatiza666
Copy link
Collaborator

Open modal popup with non-editable config of the connector
Fix #1089

Is this a user-visible change (yes/no): yes

@Karakatiza666 Karakatiza666 added enhancement New feature or request Web Console Related to the browser based UI javascript Pull requests that update Javascript code User-facing For PRs that lead to Feldera-user visible changes labels Dec 11, 2023
@Karakatiza666
Copy link
Collaborator Author

image
image

@Karakatiza666 Karakatiza666 force-pushed the connector-thumb branch 3 times, most recently from a6132d2 to 854ae95 Compare December 11, 2023 20:18
Copy link

github-actions bot commented Dec 11, 2023

✅ Meticulous spotted zero visual differences across 6 screens tested: view results.

Last updated for commit 9290f18. This comment will update as new commits are pushed.

@gz
Copy link
Collaborator

gz commented Dec 11, 2023

If I inspect the connector and then close it, I'm out of the connector list and have to select a type again:

Screencast.from.12-11-2023.12.22.40.PM.webm

it should keep the list where I clicked the Inspect button open.

@gz
Copy link
Collaborator

gz commented Dec 11, 2023

there used to be icons here?

Screenshot from 2023-12-11 12-25-42

@gz
Copy link
Collaborator

gz commented Dec 11, 2023

if I add connectors, connect them, then refresh, it opens the drawer again even though I closed it earlier:

Screencast.from.12-11-2023.12.28.31.PM.webm

@gz
Copy link
Collaborator

gz commented Dec 11, 2023

I think the > should not appear as long as we havent selected a connector type (and have a table view)

Screenshot from 2023-12-11 12-30-35

Copy link
Collaborator

@gz gz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside from comments above

Open modal popup with non-editable config of the connector

Signed-off-by: George <bulakh.96@gmail.com>
@Karakatiza666
Copy link
Collaborator Author

Fixed closing popup not returning to connector list (bug in production build).
The icons missing (Firefox only) and drawer opening on reload is a regression from another commit.

@Karakatiza666 Karakatiza666 merged commit 40c9b1d into main Dec 11, 2023
6 checks passed
@Karakatiza666 Karakatiza666 deleted the connector-thumb branch December 11, 2023 21:15
@gz
Copy link
Collaborator

gz commented Dec 12, 2023

The icons missing (Firefox only) and drawer opening on reload is a regression from another commit.

do we have issues for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code User-facing For PRs that lead to Feldera-user visible changes Web Console Related to the browser based UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI should show Input Source properties when adding it to a pipeline
2 participants