-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Inspect connector' button to the connector list in Pipeline Builder #1128
Conversation
a6132d2
to
854ae95
Compare
✅ Meticulous spotted zero visual differences across 6 screens tested: view results. Last updated for commit 9290f18. This comment will update as new commits are pushed. |
If I inspect the connector and then close it, I'm out of the connector list and have to select a type again: Screencast.from.12-11-2023.12.22.40.PM.webmit should keep the list where I clicked the Inspect button open. |
if I add connectors, connect them, then refresh, it opens the drawer again even though I closed it earlier: Screencast.from.12-11-2023.12.28.31.PM.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm aside from comments above
Open modal popup with non-editable config of the connector Signed-off-by: George <bulakh.96@gmail.com>
854ae95
to
9290f18
Compare
Fixed closing popup not returning to connector list (bug in production build). |
do we have issues for it? |
Open modal popup with non-editable config of the connector
Fix #1089
Is this a user-visible change (yes/no): yes