pipeline-manager: use names instead of IDs in API endpoints #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalithsuresh
force-pushed
the
names-in-urls
branch
2 times, most recently
from
2cb6d6b
to
fe26c1a
Compare
lalithsuresh
force-pushed
the
names-in-urls
branch
6 times, most recently
from
8835e65
to
fc1a6db
Compare
snkas
approved these changes
Jan 3, 2024
lalithsuresh
force-pushed
the
names-in-urls
branch
from
0712f01
to
883dbdf
Compare
1 task
Merged
snkas
reviewed
Jan 16, 2024
… of IDs Signed-off-by: Lalith Suresh <lalith@feldera.com>
lalithsuresh
force-pushed
the
names-in-urls
branch
2 times, most recently
from
a325d42
to
3c8c2f2
Compare
|
✅ Meticulous spotted zero visual differences across 7 screens tested: view results. Last updated for commit b43eeeb. This comment will update as new commits are pushed. |
lalithsuresh
force-pushed
the
names-in-urls
branch
from
3c8c2f2
to
a50913c
Compare
…d of IDs Signed-off-by: Lalith Suresh <lalith@feldera.com>
… in URLs Signed-off-by: Lalith Suresh <lalith@feldera.com>
lalithsuresh
force-pushed
the
names-in-urls
branch
from
444b04e
to
ba92285
Compare
…in URLs Signed-off-by: Lalith Suresh <lalith@feldera.com>
Signed-off-by: Lalith Suresh <lalith@feldera.com>
Signed-off-by: Lalith Suresh <lalith@feldera.com>
Signed-off-by: Lalith Suresh <lalith@feldera.com>
Signed-off-by: Lalith Suresh <lalith@feldera.com>
* Refactor UI to use API object names instead of IDs * Refactor Program Editor page to support new API * Refactor Pipeline Builderand Connector dialogs to suport the new AI * Fix updating pipeline name bugged out, fi renaming detached conecors * Code cleanup * Improv state management in SQL Editor page * Adjust UI test, fix navigating to a pipeline on ipeline List page * Fix program filing to rename inPipeline age * Fix not being able to edit program data when name collision is detected * Fix not being able to edit program data when name collision is detected * Fix pipeline program not getting deleted in a new pipeline * Fix Pipeline name not editable on Pipeline Management page * Change name collision error message Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
lalithsuresh
force-pushed
the
names-in-urls
branch
from
ba92285
to
b43eeeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the Programs, Connectors and Pipelines API endpoints to use names instead of IDs in their URLs (e.g.,
GET /v0/pipelines/foo).This obviously breaks the UI, so we'll need @Karakatiza666's help to finalize. I will need to do another pass on the demos as well before this is merged.
Once this is in, I'll move towards improving our API documentation.
Signed-off-by: Lalith Suresh lalith@feldera.com
Is this a user-visible change (yes/no): yes