[SQL] Add hyperbolic functions #1280
Conversation
abhizer
added
documentation
| 1.5430806348152437 | ||
| (1 row) | ||
|
|
||
| SELECT coth(0.6); -- not tested in Spark |
There was a problem hiding this comment.
It isn't available in Spark.
There was a problem hiding this comment.
I would have said "not available in Spark"
| #[inline(always)] | ||
| pub fn sec_d(value: F64) -> F64 { | ||
| let cos = value.into_inner().cos(); | ||
| if cos.is_zero() { |
There was a problem hiding this comment.
Rust doesn't have sec?
Also, if you just do the division with 0 don't you get the same result?
Or maybe the result can be -infinity sometimes?
There was a problem hiding this comment.
Actually yeah, its Infinity even if we divide by 0. I was expecting a division by 0 error, but turns out it gives inf if the number being divided is positive and -inf if the number being divided is negative.
| if tanh.is_zero() { | ||
| f64::INFINITY.into() | ||
| } else { | ||
| (1.0 / tanh).into() |
There was a problem hiding this comment.
same question about division
| pub fn atanh_d(value: F64) -> F64 { | ||
| let inner = value.into_inner(); | ||
| if !(-1.0..=1.0).contains(&inner) && !inner.is_nan() { | ||
| panic!("input out of range") |
There was a problem hiding this comment.
the error message should probably be more informative, including the actual value and the range.
we'll also add position at some point.
There was a problem hiding this comment.
Ah okay, will add the value to the error message.
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
* Remove unnecessary check for zero Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
abhizer
force-pushed
the
hyperbolic_functions
branch
from
71f3414
to
78635db
Compare
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
|
Did proptest find a bug here? |
Is this a user-visible change (yes/no): yes
Partially fixes: #1265