-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline-manager: add a config API endpoint to get a list of canned demo URLs #1385
Conversation
d746516
to
16c203a
Compare
|
Command to run it directly:
... and then you can check the endpoint using:
|
@snkas My understanding was that the title and description will be encoded in the json file that describes the demo. I don't think we need to repeat that in the CLI argument here. Besides, it'll be a pain to render via Helm with all the escaping. :) |
@lalithsuresh , @Karakatiza666 had a strong preference to have the name and description be part of the demo list itself I think for UI placeholders while the demo JSON is loaded in. I agree it becomes a pain in terms of escaping when passing serialized JSON... We can keep it a list of URLs in this first version and then revisit it later on. What do you think @Karakatiza666 ? |
Reverted to just a list of strings (URLs). |
Split off the canned demo warehouse to separate PR: #1401 Command to run it directly:
... and then you can check the endpoint using:
|
…emo URLs (#1385) Co-authored-by: Lalith Suresh <lalith@feldera.com> Signed-off-by: Lalith Suresh <lalith@feldera.com> Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
Ready for final review Notes:
|
security(("JSON web token (JWT) or API key" = [])), | ||
tag = "Configuration", | ||
)] | ||
#[get("/config/demos")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to be under /config
? Seems like demos should be a separate tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning is I think that it is part of the configuration with which you start the pipeline-manager (it is provided as a command-line argument), as such you fetch it from the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I get it. I do think it's a bit of a stretch, but I'm ok with it.
…emo URLs (#1385) Co-authored-by: Lalith Suresh <lalith@feldera.com> Signed-off-by: Lalith Suresh <lalith@feldera.com> Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
Co-authored-by: Lalith Suresh <lalith@feldera.com> Signed-off-by: Lalith Suresh <lalith@feldera.com> Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
Co-authored-by: Lalith Suresh <lalith@feldera.com> Signed-off-by: Lalith Suresh <lalith@feldera.com> Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
Rebased with main, awaiting CI to pass to merge. Changes:
|
Signed-off-by: Lalith Suresh lalith@feldera.com
Is this a user-visible change (yes/no): yes