[SQL] implement ARRAY_CONTAINS function #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
mihaibudiu
requested changes
Mar 6, 2024
docs/sql/array.md
Outdated
| @@ -40,6 +40,7 @@ as `CREATE TABLE data AS (CITIES VARCHAR ARRAY, COUNTRY VARCHAR)`. | |||
| |----------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------| | |||
| | _array_`[`_index_`]` | where _index_ is an expression that evaluates to an integer, and _array_ is an expression that evaluates to an array. Returns the element at the specified position. If the index is out of bounds, the result is `NULL`. | `ARRAY[2,3][2]` => 3 | | |||
| | `ARRAY_APPEND(` _array_ `, ` _element_ `)` | Appends an element to the end of the array and returns the result. If the array is `NULL`, the function will return `NULL`. If the _element_ is `NULL`, the `NULL` element will be added to the end of the array. | `ARRAY_APPEND(ARRAY [1, 2], 3)` => `[1, 2, 3]` | | |||
| | `ARRAY_CONTAINS(` _array_ `, ` _element_ `)` | Returns true if the _array_ contains the _element_ | `ARRAY_CONTAINS(ARRAY [1, 2, 3], 2)` => true | | |||
There was a problem hiding this comment.
this also behaves strange for nulls
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com> update changelog.md Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com> update docs Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
mihaibudiu
reviewed
Mar 7, 2024
docs/sql/array.md
Outdated
| @@ -41,6 +41,7 @@ as `CREATE TABLE data AS (CITIES VARCHAR ARRAY, COUNTRY VARCHAR)`. | |||
| | _array_`[`_index_`]` | where _index_ is an expression that evaluates to an integer, and _array_ is an expression that evaluates to an array. Returns the element at the specified position. If the index is out of bounds, the result is `NULL`. | `ARRAY[2,3][2]` => 3 | | |||
| | `ARRAY_APPEND(` _array_ `, ` _element_ `)` | Appends an element to the end of the array and returns the result. If the array is `NULL`, the function will return `NULL`. If the _element_ is `NULL`, the `NULL` element will be added to the end of the array. | `ARRAY_APPEND(ARRAY [1, 2], 3)` => `[1, 2, 3]` | | |||
| | `ARRAY_COMPACT(` _array_ `)` | Returns a new array by removing all the `NULL` values from the _array_ | `ARRAY_COMPACT(ARRAY [1, 2, 3, NULL])` => `[1, 2, 3]` | | |||
| | `ARRAY_CONTAINS(` _array_ `, ` _element_ `)` | Returns true if the _array_ contains the _element_. If _element_ is `NULL`, `NULL` is returned. | `ARRAY_CONTAINS(ARRAY [1, 2, 3], 2)` => true | | |||
There was a problem hiding this comment.
I would swap these two in the description, because the second one takes priority.
There was a problem hiding this comment.
btw, please review the other descriptions to see if this change should be applied to them as well.
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
mihaibudiu
approved these changes
Mar 8, 2024
Signed-off-by: Mihai Budiu <mbudiu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a user-visible change (yes/no): yes