Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First iteration of error reporting, show memory usage, data row deletion #610

Merged
merged 15 commits into from
Sep 8, 2023

Conversation

Karakatiza666
Copy link
Collaborator

#532 (home page only)
#528 (backend inconsistently reports of memory usage)
#525 (backend error)

@Karakatiza666 Karakatiza666 requested a review from gz August 31, 2023 17:01
@github-actions
Copy link

github-actions bot commented Aug 31, 2023

🤖 Meticulous spotted visual differences in 4 of 102 screens tested: view and approve differences detected.

Last updated for commit be88dd5. This comment will update as new commits are pushed.

@gz
Copy link
Collaborator

gz commented Sep 4, 2023

  • This needs a space here between number and 'Rows'
    Screenshot from 2023-09-04 02-23-31

  • The copy button overlaps with text here can we make it so it's not overlapping:
    Screenshot from 2023-09-04 02-26-52

  • Looks like pipeline failures currently don't have a report button, just the SQL programs? Ideally we can report also pipeline failures I think:
    Screenshot from 2023-09-04 02-26-52

  • When I clicked report on a failed to compile SQL program, this happened instead of being able to report:
    Screenshot from 2023-09-04 02-28-22

@ryzhyk
Copy link
Contributor

ryzhyk commented Sep 4, 2023

#528 (backend inconsistently reports of memory usage)

@Karakatiza666 , what exactly is the problem with memory usage reporting?

@Karakatiza666
Copy link
Collaborator Author

@ryzhyk In all my builds memory usage via rss_bytes is only reported in GreenTrip pipeline, everywhere else it's zero

@ryzhyk
Copy link
Contributor

ryzhyk commented Sep 5, 2023

@ryzhyk In all my builds memory usage via rss_bytes is only reported in GreenTrip pipeline, everywhere else it's zero

Does this happen when the pipeline is running?

@gz
Copy link
Collaborator

gz commented Sep 6, 2023

Just a few more things I noticed:

  • The overlapping of the button with text in the background still looks a bit ugly:
    Screenshot from 2023-09-05 17-00-56
    Maybe the way to fix is is to have a header / title which ensures the button can't overlap with any text?
    image

  • There is a now a searchbar in the drawer tables. We can probably have a search bar if there are many connectors but if there is just a few maybe we shouldn't display the search bar?
    Screenshot from 2023-09-05 17-03-11

@Karakatiza666
Copy link
Collaborator Author

If this is a regression then not from this PR - behavior is the same on latest main;
Don't see the point in complicating the code with hiding the searchbar, atleast until it takes up space from something else

Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
… use hash

Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
…ort url length

Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
Signed-off-by: George <bulakh.96@gmail.com>
@Karakatiza666 Karakatiza666 merged commit 54a8375 into main Sep 8, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants