Decouple DB migrations from connection setup #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gz
approved these changes
Oct 9, 2023
lalithsuresh
force-pushed
the
migrations
branch
from
38fb8eb
to
1824b57
Compare
Signed-off-by: Lalith Suresh <suresh.lalith@gmail.com>
Signed-off-by: Lalith Suresh <suresh.lalith@gmail.com>
Signed-off-by: Lalith Suresh <suresh.lalith@gmail.com>
lalithsuresh
force-pushed
the
migrations
branch
from
1824b57
to
3400b7e
Compare
Signed-off-by: Lalith Suresh <suresh.lalith@gmail.com>
lalithsuresh
force-pushed
the
migrations
branch
from
3400b7e
to
a5746c1
Compare
Signed-off-by: Lalith Suresh <suresh.lalith@gmail.com>
lalithsuresh
force-pushed
the
migrations
branch
from
a5746c1
to
e753236
Compare
lalithsuresh
added a commit
that referenced
this pull request
Oct 10, 2023
Signed-off-by: Lalith Suresh <suresh.lalith@gmail.com>
lalithsuresh
added a commit
that referenced
this pull request
Oct 10, 2023
Signed-off-by: Lalith Suresh <suresh.lalith@gmail.com>
lalithsuresh
added a commit
that referenced
this pull request
Oct 10, 2023
Signed-off-by: Lalith Suresh <suresh.lalith@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently perform database migrations while initializing connections. This is fraught with risks in a production setting (e.g., makes rollbacks difficult).
This PR separates out running migrations from the connection initialization code. The pipeline-manager all-in-one binary should appear no different than before. The individual service binaries however no longer run migrations on their own. They are complemented with a new binary that does nothing but connect to the DB and runs the migration.
Is this a user-visible change (yes/no): yes