Avoid force-shutdowns for pipelines that encounter errors during lifecycle state changes #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalithsuresh
changed the title
lalithsuresh
force-pushed
the
failure-behavior
branch
from
260e800
to
c7e99ed
Compare
ryzhyk
reviewed
Oct 11, 2023
ryzhyk
approved these changes
Oct 11, 2023
lalithsuresh
force-pushed
the
failure-behavior
branch
from
e21f1e1
to
60ec850
Compare
Several state transitions in the pipeline automata shutdown the pipeline the moment it encounters a failure. This behavior is undesirable in production settings where pipelines can fail for myriad reasons, and it's good to have them stick around to be diagnosed. Pipelines can anyhow only be restarted via the /start action after an explicit shutdown by the user. Signed-off-by: Lalith Suresh <lalith@feldera.com>
Signed-off-by: Lalith Suresh <lalith@feldera.com>
lalithsuresh
force-pushed
the
failure-behavior
branch
from
60ec850
to
f183c89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several state transitions in the pipeline automata shutdown the pipeline the moment it encounters a failure. This behavior is undesirable in production settings where pipelines can fail for myriad reasons, and it's good to have them stick around to be diagnosed.
Pipelines can anyhow only be restarted via the /start action after an explicit shutdown by the user.
Is this a user-visible change (yes/no): yes