Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-console: number of records in pipeline table is no longer rounded #967

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

snkas
Copy link
Contributor

@snkas snkas commented Nov 1, 2023

Removes any rounding of the number of records, instead directly printing the number (see also #926).

Is this a user-visible change (yes/no): yes

@snkas snkas added enhancement New feature or request Web Console Related to the browser based UI User-facing For PRs that lead to Feldera-user visible changes labels Nov 1, 2023
@snkas snkas force-pushed the number-of-records-no-rounding branch from 42a2400 to 2aaa637 Compare November 1, 2023 15:21
Copy link

github-actions bot commented Nov 1, 2023

✅ Meticulous spotted zero visual differences across 6 screens tested: view results.

Last updated for commit 7909ed2. This comment will update as new commits are pushed.

Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
@snkas snkas force-pushed the number-of-records-no-rounding branch from 2aaa637 to 7909ed2 Compare November 1, 2023 16:52
@snkas
Copy link
Contributor Author

snkas commented Nov 1, 2023

Formatted now as the whole number with comma separator for thousands.

@snkas snkas merged commit 49d2ae4 into main Nov 1, 2023
7 checks passed
@snkas snkas deleted the number-of-records-no-rounding branch November 1, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request User-facing For PRs that lead to Feldera-user visible changes Web Console Related to the browser based UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants