Change default secrets directory and update related terminology #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snkas
added
adapters
snkas
force-pushed
the
secrets-directory
branch
from
1639b99
to
acf662f
Compare
lalithsuresh
approved these changes
Nov 2, 2023
Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
snkas
force-pushed
the
secrets-directory
branch
from
acf662f
to
76bbf54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default secrets directory from
/etc/secret-volumeto/etc/secrets.In addition, changes some comment and variable terminology to be more in line with a directory in which there are secrets as files.
Is this a user-visible change (yes/no): yes