Remove FLOAT SQL datatype #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #950 |
|
This needs some code removal in the web-console too @Karakatiza666 |
gz
approved these changes
Nov 7, 2023
CHANGELOG.md
Outdated
| @@ -10,6 +10,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Removed suppoer for FLOAT SQL data type, since it is ambiguous. | |||
There was a problem hiding this comment.
Suggested change
| - Removed suppoer for FLOAT SQL data type, since it is ambiguous. | |
| ### Removed | |
| - Removed support for FLOAT SQL data type, since it is ambiguous. | |
| ### Added |
lalithsuresh
approved these changes
Nov 7, 2023
| @@ -17,7 +17,7 @@ The compiler supports the following SQL data types: | |||
| digits) and a scale (number of decimal digits after period). For example, | |||
| 23.456 has a precision of 5 and a scale of 3. If scale is missing it is | |||
| assumed to be 0. | |||
| - `FLOAT`, or `FLOAT4`, or `FLOAT32`, or `REAL`, an IEEE 32-bit floating point number | |||
| - `REAL`, or `FLOAT4`, or `FLOAT32`, an IEEE 32-bit floating point number | |||
There was a problem hiding this comment.
Are FLOAT4 and FLOAT32 accepted types?
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a user-visible change (yes/no): yes