[SQL] Reorganize tests, more aggregation functions #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
force-pushed
the
varbinary
branch
2 times, most recently
from
218137b
to
4b0b213
Compare
|
Anyone wants to review this? |
lalithsuresh
approved these changes
Nov 11, 2023
| let self_len = self.data.len(); | ||
| let other_len = other.data.len(); | ||
| if self_len != other_len { | ||
| panic!("Cannot operate on BINARY objects of different sizes {} and {}", |
There was a problem hiding this comment.
Wouldn't this kill the entire pipeline?
There was a problem hiding this comment.
Right, that's #297
We don't have any solution right now.
This is the semantics of SQL.
mihaibudiu
force-pushed
the
varbinary
branch
from
4b0b213
to
59c9e1d
Compare
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
force-pushed
the
varbinary
branch
from
59c9e1d
to
fee4ae4
Compare
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
force-pushed
the
varbinary
branch
from
fee4ae4
to
a535951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a user-visible change (yes/no): yes
There are several things going on in this PR.
First, I reorganized the tests in directories. I have started getting some tests from mysql too. So we have hand-writtten tests, mysql tests, postgres tests, jit tests, foodmart tests (taken from Calcite), and testsuites (e.g., TPCH, and nexmark).
Second, I implemented bitwise operations for byte arrays (BINARY or VARBINARY type).
Third, I implemented more aggregation functions, like BIT_AND, BIT_XOR, and BIT_OR. These work for integers, but also for BINARY types.
I also implemented the TO_HEX and concatenation function on BINARY values.