Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ConnectionError handler #57

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Implement ConnectionError handler #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/services/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ def make_request(self, url: Optional[str] = None) -> Response:
)
except TooManyRedirects:
raise HTTPException(status_code=404, detail=f"Not found for url: {url}")
except ConnectionError:
raise HTTPException(status_code=500, detail=f"Connection error for url: {url}")
Comment on lines +61 to +62
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching ConnectionError and raising an HTTPException with a 500 status code is not entirely appropriate. A ConnectionError typically indicates a problem with the network connection, which might be more accurately represented by a 503 Service Unavailable status code, as it suggests the service is temporarily unavailable.

-            raise HTTPException(status_code=500, detail=f"Connection error for url: {url}")
+            raise HTTPException(status_code=503, detail=f"Service Unavailable for url: {url}")
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
except ConnectionError:
raise HTTPException(status_code=500, detail=f"Connection error for url: {url}")
except ConnectionError:
raise HTTPException(status_code=503, detail=f"Service Unavailable for url: {url}")

except Exception as e:
raise HTTPException(status_code=500, detail=f"Error for url: {url}. {e}")
Comment on lines +63 to +64
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching a generic Exception is a good practice for capturing unexpected errors, but it's important to log these exceptions for debugging purposes. The current implementation only raises an HTTPException without logging, which could make it difficult to diagnose issues later on.

Consider logging the exception before raising the HTTPException to ensure that there is a record of what went wrong.

if 400 <= response.status_code < 500:
raise HTTPException(
status_code=response.status_code,
Expand Down
Loading