Skip to content

Commit

Permalink
fix: Ensure that every NdapiObject has its internal type set
Browse files Browse the repository at this point in the history
  • Loading branch information
felipebz committed Dec 27, 2023
1 parent 3004c04 commit a055c81
Show file tree
Hide file tree
Showing 42 changed files with 44 additions and 43 deletions.
2 changes: 1 addition & 1 deletion Ndapi/Alert.cs
Expand Up @@ -27,7 +27,7 @@ public Alert(ObjectGroup group, string name) : base(name, ObjectType.Alert, grou
{
}

internal Alert(ObjectSafeHandle handle) : base(handle)
internal Alert(ObjectSafeHandle handle) : base(handle, ObjectType.Alert)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/AttachedLibrary.cs
Expand Up @@ -39,7 +39,7 @@ public AttachedLibrary(MenuModule module, string location)
Ensure.Success(status);
}

internal AttachedLibrary(ObjectSafeHandle handle) : base(handle)
internal AttachedLibrary(ObjectSafeHandle handle) : base(handle, ObjectType.AttachedLibrary)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Block.cs
Expand Up @@ -27,7 +27,7 @@ public Block(ObjectGroup group, string name) : base(name, ObjectType.Block, grou
{
}

internal Block(ObjectSafeHandle handle) : base(handle)
internal Block(ObjectSafeHandle handle) : base(handle, ObjectType.Block)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/BlockRelation.cs
Expand Up @@ -18,7 +18,7 @@ public BlockRelation(Block module, string name) : base(name, ObjectType.BlockRel
{
}

internal BlockRelation(ObjectSafeHandle handle) : base(handle)
internal BlockRelation(ObjectSafeHandle handle) : base(handle, ObjectType.BlockRelation)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Canvas.cs
Expand Up @@ -27,7 +27,7 @@ public Canvas(ObjectGroup group, string name) : base(name, ObjectType.Canvas, gr
{
}

internal Canvas(ObjectSafeHandle handle) : base(handle)
internal Canvas(ObjectSafeHandle handle) : base(handle, ObjectType.Canvas)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/ColumnMapping.cs
Expand Up @@ -18,7 +18,7 @@ public ColumnMapping(LOV lov, string name) : base(name, ObjectType.ColumnMapping
{
}

internal ColumnMapping(ObjectSafeHandle handle) : base(handle)
internal ColumnMapping(ObjectSafeHandle handle) : base(handle, ObjectType.ColumnMapping)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/CompoundText.cs
Expand Up @@ -18,7 +18,7 @@ public CompoundText(Graphics graphics, string name) : base(name, ObjectType.Comp
{
}

internal CompoundText(ObjectSafeHandle handle) : base(handle)
internal CompoundText(ObjectSafeHandle handle) : base(handle, ObjectType.CompoundText)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Coordinate.cs
Expand Up @@ -28,7 +28,7 @@ public Coordinate(FormModule module) : this()
Extract(module);
}

internal Coordinate(ObjectSafeHandle handle) : base(handle)
internal Coordinate(ObjectSafeHandle handle) : base(handle, ObjectType.Coordinate)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/DataSourceArgument.cs
Expand Up @@ -18,7 +18,7 @@ public DataSourceArgument(Block block, string name) : base(name, ObjectType.Data
{
}

internal DataSourceArgument(ObjectSafeHandle handle) : base(handle)
internal DataSourceArgument(ObjectSafeHandle handle) : base(handle, ObjectType.DataSourceArgument)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/DataSourceColumn.cs
Expand Up @@ -18,7 +18,7 @@ public DataSourceColumn(Block block, string name) : base(name, ObjectType.DataSo
{
}

internal DataSourceColumn(ObjectSafeHandle handle) : base(handle)
internal DataSourceColumn(ObjectSafeHandle handle, ObjectType type) : base(handle, type)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Editor.cs
Expand Up @@ -27,7 +27,7 @@ public Editor(ObjectGroup group, string name) : base(name, ObjectType.Editor, gr
{
}

internal Editor(ObjectSafeHandle handle) : base(handle)
internal Editor(ObjectSafeHandle handle) : base(handle, ObjectType.Editor)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Event.cs
Expand Up @@ -28,7 +28,7 @@ public Event(ObjectGroup group, string name) : base(name, ObjectType.Event, grou
{
}

internal Event(ObjectSafeHandle handle) : base(handle)
internal Event(ObjectSafeHandle handle) : base(handle, ObjectType.Event)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Font.cs
Expand Up @@ -29,7 +29,7 @@ public Font(NdapiObject obj, VisualAttributeType type) : this()
Extract(obj, type);
}

internal Font(ObjectSafeHandle handle) : base(handle)
internal Font(ObjectSafeHandle handle) : base(handle, ObjectType.Font)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/FormModule.cs
Expand Up @@ -17,7 +17,7 @@ public FormModule(string name) : base(name, ObjectType.FormModule)
{
}

internal FormModule(ObjectSafeHandle handle) : base(handle)
internal FormModule(ObjectSafeHandle handle) : base(handle, ObjectType.FormModule)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/FormParameter.cs
Expand Up @@ -18,7 +18,7 @@ public FormParameter(FormModule module, string name) : base(name, ObjectType.For
{
}

internal FormParameter(ObjectSafeHandle handle) : base(handle)
internal FormParameter(ObjectSafeHandle handle) : base(handle, ObjectType.FormParameter)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Graphics.cs
Expand Up @@ -45,7 +45,7 @@ public Graphics(TabPage tab, string name) : base(name, ObjectType.Graphics, tab)
{
}

internal Graphics(ObjectSafeHandle handle) : base(handle)
internal Graphics(ObjectSafeHandle handle) : base(handle, ObjectType.Graphics)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Item.cs
Expand Up @@ -29,7 +29,7 @@ public Item(ObjectGroup group, string name) : base(name, ObjectType.Item, group)
{
}

internal Item(ObjectSafeHandle handle) : base(handle)
internal Item(ObjectSafeHandle handle) : base(handle, ObjectType.Item)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/LOV.cs
Expand Up @@ -27,7 +27,7 @@ public LOV(ObjectGroup group, string name) : base(name, ObjectType.LOV, group)
{
}

internal LOV(ObjectSafeHandle handle) : base(handle)
internal LOV(ObjectSafeHandle handle) : base(handle, ObjectType.LOV)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/LibraryModule.cs
Expand Up @@ -11,7 +11,7 @@ namespace Ndapi;
/// </summary>
public class LibraryModule : NdapiModule
{
internal LibraryModule(ObjectSafeHandle handle) : base(handle)
internal LibraryModule(ObjectSafeHandle handle) : base(handle, ObjectType.LibraryModule)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/LibraryProgramUnit.cs
Expand Up @@ -9,7 +9,7 @@ namespace Ndapi;
/// </summary>
public class LibraryProgramUnit : NdapiObject<LibraryProgramUnit>
{
internal LibraryProgramUnit(ObjectSafeHandle handle) : base(handle)
internal LibraryProgramUnit(ObjectSafeHandle handle) : base(handle, ObjectType.LibraryProgramUnit)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Menu.cs
Expand Up @@ -27,7 +27,7 @@ public Menu(MenuModule module, string name) : base(name, ObjectType.Menu, module
{
}

internal Menu(ObjectSafeHandle handle) : base(handle)
internal Menu(ObjectSafeHandle handle) : base(handle, ObjectType.Menu)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/MenuItem.cs
Expand Up @@ -29,7 +29,7 @@ public MenuItem(ObjectGroup group, string name) : base(name, ObjectType.MenuItem
{
}

internal MenuItem(ObjectSafeHandle handle) : base(handle)
internal MenuItem(ObjectSafeHandle handle) : base(handle, ObjectType.MenuItem)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/MenuModule.cs
Expand Up @@ -19,7 +19,7 @@ public MenuModule(string name) : base(name, ObjectType.MenuModule)
{
}

internal MenuModule(ObjectSafeHandle handle) : base(handle)
internal MenuModule(ObjectSafeHandle handle) : base(handle, ObjectType.MenuModule)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/MenuParameter.cs
Expand Up @@ -20,7 +20,7 @@ public MenuParameter(MenuModule module, string name) : base(name, ObjectType.Men
{
}

internal MenuParameter(ObjectSafeHandle handle) : base(handle)
internal MenuParameter(ObjectSafeHandle handle) : base(handle, ObjectType.MenuParameter)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/NdapiModule.cs
Expand Up @@ -17,7 +17,7 @@ internal NdapiModule(string name, ObjectType type, NdapiObject parent = null) :
NdapiContext.AddModule(this);
}

internal NdapiModule(ObjectSafeHandle handle) : base(handle)
internal NdapiModule(ObjectSafeHandle handle, ObjectType type) : base(handle, type)
{
NdapiContext.AddModule(this);
}
Expand Down
5 changes: 3 additions & 2 deletions Ndapi/NdapiObject.cs
Expand Up @@ -37,9 +37,10 @@ internal NdapiObject(string name, ObjectType type, NdapiObject parent = null)
_type = type;
}

internal NdapiObject(ObjectSafeHandle handle) : this()
internal NdapiObject(ObjectSafeHandle handle, ObjectType type) : this()
{
_handle = handle;
_type = type;
}

/// <summary>
Expand Down Expand Up @@ -517,7 +518,7 @@ public abstract class NdapiObject<[DynamicallyAccessedMembers(DynamicallyAccesse
internal NdapiObject() { }
internal NdapiObject(ObjectType type) : base(type) { }
internal NdapiObject(string name, ObjectType type, NdapiObject parent = null) : base(name, type, parent) { }
internal NdapiObject(ObjectSafeHandle handle) : base(handle) { }
internal NdapiObject(ObjectSafeHandle handle, ObjectType type) : base(handle, type) { }

/// <summary>
/// Get the previous object.
Expand Down
2 changes: 1 addition & 1 deletion Ndapi/ObjectGroup.cs
Expand Up @@ -27,7 +27,7 @@ public ObjectGroup(MenuModule module, string name) : base(name, ObjectType.Objec
{
}

internal ObjectGroup(ObjectSafeHandle handle) : base(handle)
internal ObjectGroup(ObjectSafeHandle handle) : base(handle, ObjectType.ObjectGroup)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/ObjectGroupChild.cs
Expand Up @@ -19,7 +19,7 @@ public ObjectGroupChild(ObjectGroup group, string name) : base(name, ObjectType.
{
}

internal ObjectGroupChild(ObjectSafeHandle handle) : base(handle)
internal ObjectGroupChild(ObjectSafeHandle handle) : base(handle, ObjectType.ObjectGroupChild)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/ObjectLibrary.cs
Expand Up @@ -19,7 +19,7 @@ public ObjectLibrary(string name) : base(name, ObjectType.ObjectLibrary)
{
}

internal ObjectLibrary(ObjectSafeHandle handle) : base(handle)
internal ObjectLibrary(ObjectSafeHandle handle) : base(handle, ObjectType.ObjectLibrary)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/ObjectLibraryTab.cs
Expand Up @@ -21,7 +21,7 @@ public ObjectLibraryTab(ObjectLibrary library, string name) : base(name, ObjectT
ObjectLibrary = library;
}

internal ObjectLibraryTab(ObjectSafeHandle handle) : base(handle)
internal ObjectLibraryTab(ObjectSafeHandle handle) : base(handle, ObjectType.ObjectLibraryTab)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Point.cs
Expand Up @@ -18,7 +18,7 @@ public Point(Graphics graphics, string name) : base(name, ObjectType.Point, grap
{
}

internal Point(ObjectSafeHandle handle) : base(handle)
internal Point(ObjectSafeHandle handle) : base(handle, ObjectType.Point)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/ProgramUnit.cs
Expand Up @@ -36,7 +36,7 @@ public ProgramUnit(ObjectGroup module, string name) : base(name, ObjectType.Prog
{
}

internal ProgramUnit(ObjectSafeHandle handle) : base(handle)
internal ProgramUnit(ObjectSafeHandle handle) : base(handle, ObjectType.ProgramUnit)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/PropertyClass.cs
Expand Up @@ -45,7 +45,7 @@ public PropertyClass(LibraryModule library, string name) : base(name, ObjectType
{
}

internal PropertyClass(ObjectSafeHandle handle) : base(handle)
internal PropertyClass(ObjectSafeHandle handle) : base(handle, ObjectType.PropertyClass)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/RadioButton.cs
Expand Up @@ -18,7 +18,7 @@ public RadioButton(Item item, string name) : base(name, ObjectType.RadioButton,
{
}

internal RadioButton(ObjectSafeHandle handle) : base(handle)
internal RadioButton(ObjectSafeHandle handle) : base(handle, ObjectType.RadioButton)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/RecordGroup.cs
Expand Up @@ -27,7 +27,7 @@ public RecordGroup(ObjectGroup group, string name) : base(name, ObjectType.Recor
{
}

internal RecordGroup(ObjectSafeHandle handle) : base(handle)
internal RecordGroup(ObjectSafeHandle handle) : base(handle, ObjectType.RecordGroup)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/RecordGroupColumn.cs
Expand Up @@ -20,7 +20,7 @@ public RecordGroupColumn(RecordGroup module, string name) : base(name, ObjectTyp
{
}

internal RecordGroupColumn(ObjectSafeHandle handle) : base(handle)
internal RecordGroupColumn(ObjectSafeHandle handle) : base(handle, ObjectType.ColumnSpecification)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Report.cs
Expand Up @@ -18,7 +18,7 @@ public Report(FormModule module, string name) : base(name, ObjectType.Report, mo
{
}

internal Report(ObjectSafeHandle handle) : base(handle)
internal Report(ObjectSafeHandle handle) : base(handle, ObjectType.Report)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/TabPage.cs
Expand Up @@ -18,7 +18,7 @@ public TabPage(Canvas canvas, string name) : base(name, ObjectType.TabPage, canv
{
}

internal TabPage(ObjectSafeHandle handle) : base(handle)
internal TabPage(ObjectSafeHandle handle) : base(handle, ObjectType.TabPage)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/TextSegment.cs
Expand Up @@ -18,7 +18,7 @@ public TextSegment(CompoundText compoundText, string name) : base(name, ObjectTy
{
}

internal TextSegment(ObjectSafeHandle handle) : base(handle)
internal TextSegment(ObjectSafeHandle handle) : base(handle, ObjectType.TextSegment)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Trigger.cs
Expand Up @@ -54,7 +54,7 @@ public Trigger(PropertyClass propertyClass, string name) : base(name, ObjectType
{
}

internal Trigger(ObjectSafeHandle handle) : base(handle)
internal Trigger(ObjectSafeHandle handle) : base(handle, ObjectType.Trigger)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/VisualAttribute.cs
Expand Up @@ -35,7 +35,7 @@ public VisualAttribute(ObjectGroup group, string name) : base(name, ObjectType.V
{
}

internal VisualAttribute(ObjectSafeHandle handle) : base(handle)
internal VisualAttribute(ObjectSafeHandle handle) : base(handle, ObjectType.VisualAttribute)
{
}

Expand Down
2 changes: 1 addition & 1 deletion Ndapi/Window.cs
Expand Up @@ -27,7 +27,7 @@ public Window(ObjectGroup group, string name) : base(name, ObjectType.Window, gr
{
}

internal Window(ObjectSafeHandle handle) : base(handle)
internal Window(ObjectSafeHandle handle) : base(handle, ObjectType.Window)
{
}

Expand Down

0 comments on commit a055c81

Please sign in to comment.