Moved "AT" keyword from reserved to non reserved #13
Conversation
|
@felipebz, it seems that my attempt to make a second pull request merged the two commits. Feel free to reject it if you wish. What I really like to know is what gone wrong with Travis build. It did passed on ci build and failed on the three its builds. What is the difference between then? |
There was a problem hiding this comment.
Hi @nmorais.
Since last week I've added some integration tests to verify the quality of the parser against some open source projects and avoid regressions (see #4).
The Travis build is failing because your change causes a unexpected parsing error in ut_receq.pks, ftp_util_pkg and ftp_util_pkg.pkb.
Please see my comments in the code..
| @@ -37,6 +37,7 @@ | |||
| BY("by", true), | |||
| CASE("case", true), | |||
| CHECK("check", true), | |||
| COMPILE("compile", true), | |||
There was a problem hiding this comment.
"compile" is not a reserved keyword, it can be used as an identifier. See ut_receq.compile from the utPLSQL project.
| @@ -87,6 +88,7 @@ | |||
| OVERLAPS("overlaps", true), | |||
| PROCEDURE("procedure", true), | |||
| PUBLIC("public", true), | |||
| RENAME("rename", true), | |||
There was a problem hiding this comment.
"rename" is not a reserved keyword too. Example: ftp_util_pkg.rename from the alexandria-plsql-utils.
| assertThat(p).matches("alter package foo compile body;"); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
Since there are some changes to fix in PlSqlKeyword.java, you could fix the spacing here too.
Fixed spacing in AlterPlsqlUnitTest.java
|
👍 Good work. Thank you. |
The AT keyword is allowed to be used as a table alias on DML commands, so it is not a reserved keyword.