build!: set vsce as a peer dependency #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed so the users can choose which vsce version to use. This is a breaking change because users who did not install vsce as a [dev]dependency and [are not using npm@7](https://github.com/npm/rfcs/blob/latest/implemented/0025-install-peer-deps.md) will have to install vsce manually.
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
What's the use case for choosing your own vsce version? |
|
|
|
|
@felixfbecker You're right.
Actually: Do you think I should unpublish the 4.0.0? |
felipecrs
added a commit
that referenced
this pull request
Jan 18, 2021
This reverts commit 23fec9e.
felipecrs
added a commit
that referenced
this pull request
Jan 18, 2021
This reverts commit 23fec9e.
felipecrs
added a commit
that referenced
this pull request
Jan 18, 2021
This was referenced Jan 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed so the users can choose which vsce version to use. This is a breaking change because users who did not install vsce as a [dev]dependency and are not using npm@7 will have to install vsce manually.