-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update activerecord/activesupport constraints to allow Rails 6 #24
Conversation
5 similar comments
@zokioki Thanks for the PR. But it's weird that the coverage has decreased. |
@felipediesel That seems to be only for the first commit (where sqlite3 failed to install as a dev dependency) - after 94a1ccb the coverage went back up to 100%, though coveralls didn't seem to post a comment to the PR on it. |
@zokioki I realize that your changes are in fact not allowing rails 6. Only version smaller than 6. So I'm closing this PR and I have a branch ready to be merged to master. I'm also upgrading the versions tested and setting the Ruby version. |
@felipediesel Ah yes, I should have set that to read |
Rails 6 is currently in beta2 and some large shops are already running it in production; this PR updates the dependency constraints to allow for Rails 6.