Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activerecord/activesupport constraints to allow Rails 6 #24

Closed
wants to merge 2 commits into from
Closed

Conversation

zokioki
Copy link

@zokioki zokioki commented Mar 11, 2019

Rails 6 is currently in beta2 and some large shops are already running it in production; this PR updates the dependency constraints to allow for Rails 6.

@coveralls
Copy link

coveralls commented Mar 11, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 94a1ccb on zokioki:rails-6 into 22df9b0 on felipediesel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-42.1%) to 57.895% when pulling 75ed3cd on zokioki:rails-6 into 22df9b0 on felipediesel:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-42.1%) to 57.895% when pulling 75ed3cd on zokioki:rails-6 into 22df9b0 on felipediesel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-42.1%) to 57.895% when pulling 75ed3cd on zokioki:rails-6 into 22df9b0 on felipediesel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-42.1%) to 57.895% when pulling 75ed3cd on zokioki:rails-6 into 22df9b0 on felipediesel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-42.1%) to 57.895% when pulling 75ed3cd on zokioki:rails-6 into 22df9b0 on felipediesel:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-42.1%) to 57.895% when pulling 75ed3cd on zokioki:rails-6 into 22df9b0 on felipediesel:master.

@felipediesel
Copy link
Owner

@zokioki Thanks for the PR. But it's weird that the coverage has decreased.

@zokioki
Copy link
Author

zokioki commented Mar 14, 2019

@felipediesel That seems to be only for the first commit (where sqlite3 failed to install as a dev dependency) - after 94a1ccb the coverage went back up to 100%, though coveralls didn't seem to post a comment to the PR on it.

See https://coveralls.io/builds/22098724

@felipediesel
Copy link
Owner

@zokioki I realize that your changes are in fact not allowing rails 6. Only version smaller than 6. So I'm closing this PR and I have a branch ready to be merged to master. I'm also upgrading the versions tested and setting the Ruby version.

@zokioki
Copy link
Author

zokioki commented Mar 15, 2019

@felipediesel Ah yes, I should have set that to read 6.1, good catch. Thanks for merging your changes in!

@zokioki zokioki deleted the rails-6 branch March 15, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants