UI tweaks #10
Merged
UI tweaks #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in Safari
|
Thanks bro 👋 . Looks awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes some UI tweaks that I thought could be useful while I was developing #5. Let me know what you think about them.
Changes included
Do not highlight positions when it's the opponent turn
Before this change, the board positions would always be highlighted - i.e. hover effect - even when it's not my turn to play. Now, they're only highlighted when it's my turn to play.
The new behavior is demostrated on the GIF below:
Change page title
I noticed that the page title was Phoenix's default one, so I decided to update it to a more descriptive title.
Remove
word-spacingfrom logoThe log was broken on Safari due to the
word-spacingCSS property - which doesn't seem to work on Safari. I couldn't find a good solution for this, so I decided to remove it since it doesn't look that much different without it.Safari - before
Safari - now
Chrome - before
Chrome - now
I'm not really happy about this change, so let me know if you think it's better to revert it.