Fix Heap.forEach to just copy the array but keep the same references …

…to the elements inside
felipernb · Aug 15, 2014 · f92635e · f92635e
1 parent e794d88
commit f92635e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/data_structures/heap.js b/data_structures/heap.js
@@ -90,7 +90,11 @@ MinHeap.prototype.heapify = function (a) {
 };
 
 MinHeap.prototype.forEach = function (fn) {
-  var elementsCopy = JSON.parse(JSON.stringify(this._elements));
+  var elementsCopy = [];
+
+  for (var i = 0; i < this._elements.length; i++) {
+    elementsCopy.push(this._elements[i]);
+  }
 
   var element = this.extract();
   while (typeof element !== 'undefined') {

diff --git a/test/data_structures/heap.js b/test/data_structures/heap.js
@@ -65,6 +65,9 @@ describe('Min Heap', function () {
     });
 
     assert.deepEqual(output, [0, 1, 2, 3, 10, 1000]);
+
+    // Make sure nothing was really removed
+    assert.equal(h.n, 6);
   });
 });