Graham's Scan implementation #123
Conversation
| return P; | ||
| } | ||
| preprocessing(P); | ||
| console.log(P); |
There was a problem hiding this comment.
Could you please remove this debugging info?
There was a problem hiding this comment.
Sure, i forgot it.
| let j = convexHull.length; | ||
| while (j >= 2 && | ||
| vectorOp. | ||
| parallelogramArea(convexHull[j-2], convexHull[j-1], P[i]) <= 0) { |
There was a problem hiding this comment.
Can we use the isClockwise helper here? (or !isCounterClockwise)
There was a problem hiding this comment.
Actually we can't, because both isClockwise and isCounterClockwise return false when the points are collinear, but we want to remove them from the convexHull when they are collinear.
There was a problem hiding this comment.
Actually we can use !isCounterClockwise, it will do the same job. I'll change it soon.
There was a problem hiding this comment.
Looks good, but it would be nice to make two small changes:
- for consistency, always use arrow functions
- variable names always starting in lower case (i.e. the P passed to the grahamScan function).
Other than that, everything is great, thanks for the contribution!
My changes provide an implementation of the Graham's scan algorithm, basic 2D vector operations and tests for both.