Explicitly convert graph vertices to string #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (minor) problem with current graph implementation is that
vertices
property contains vertices as they were introduced toaddVertex
, butneighbors
automatically convert them to string (because internally vertices are used as object keys).It can lead to some strange results (note the types).
I understand that this “class” was designed for string vertices in mind, but it is rather common for vertices to be integers as well. String type makes it also easier to implement. The smallest possible fix I can think of is to convert vertices in graph.vertices to strings.