Improve coverage #86
Merged
Improve coverage #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some tests fixed and some new added. * Optional parameters that can actually never be omitted became mandatory. * Exceptions that check consistency inside modules replaced with asserts.
| @@ -1,5 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| var assert = require('assert'); | |||
There was a problem hiding this comment.
Not sure if it's a good idea to require assert out of the unit tests. By doing that we would add a dependency if someone wants to run the library in the browser.
There was a problem hiding this comment.
Haven't thought about that. Will remove shortly. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced with assertsremoved.