Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the name contains parenthesis, don't bring id from card (example Fairy Charm) #1

Closed
felipewove opened this issue Dec 3, 2018 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@felipewove
Copy link
Owner

This was found when importing Lost Thunder, the card Fairy Charm has 4 variants: Dragon, Fighting, Grass and Psychic and comes from LigaPokemon as Fairy Charm (Dragon), Fairy Charm (Fighting), Fairy Charm (Psychic) and Fairy Charm (Grass)

Its exporting this way, that's wrong:

Fairy Charm,,Dragon,0.20,0.97,4.90
Fairy Charm,,Fighting,0.20,0.88,4.00
Fairy Charm,,Grass,0.20,0.84,4.50
Fairy Charm,,Psychic,0.20,0.86,4.50

The correct should be:

Fairy Charm (Dragon),,177,0.20,0.97,4.90
Fairy Charm (Fighting),,176,0.20,0.88,4.00
Fairy Charm (Grass),,174,0.20,0.84,4.50
Fairy Charm (Psychic),,175,0.20,0.86,4.50
@felipewove felipewove added bug Something isn't working good first issue Good for newcomers labels Nov 24, 2019
felipewove added a commit that referenced this issue Nov 24, 2019
Fix split_name_code function and optimizations. Closes #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant