Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve conversion errors #227

Closed
felix-hilden opened this issue Nov 23, 2020 · 1 comment
Closed

Improve conversion errors #227

felix-hilden opened this issue Nov 23, 2020 · 1 comment
Assignees
@felix-hilden
Labels
enhancement New feature or improvement

Comments

@felix-hilden
Copy link
Owner

From #226, we probably should catch errors at least with unpacking URL splits to raise more informative ConversionErrors. Let's also see if other functions could also use some love.
@felix-hilden felix-hilden added the enhancement New feature or improvement label Nov 23, 2020
@felix-hilden
Copy link
Owner Author

Yeah, the same problem occurs in from_uri. We can also improve the errors of invalid prefixes by always throwing the same message with full info of the expected format.

@felix-hilden felix-hilden self-assigned this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felix-hilden felix-hilden

Labels
enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@felix-hilden