Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekore version 2.0 #176

Merged
merged 12 commits into from May 21, 2020
Merged

Tekore version 2.0 #176

merged 12 commits into from May 21, 2020

Conversation

felix-hilden
Copy link
Owner

@felix-hilden felix-hilden commented May 3, 2020

This pull request will introduce the next iteration of Tekore. As such, it contains a fair amount of breaking changes.

We'll also finally switch test runners from the builtin unittest to pytest mainly for the ease of declaring asynchronous tests with pytest-asyncio. Mocking and patching is still done with unittest though, and we ought to consider changing that. But this is a start.

@felix-hilden felix-hilden added this to the v2.0.0 milestone May 7, 2020
@felix-hilden felix-hilden added change Change behaviour of an existing component enhancement New feature or improvement labels May 7, 2020
@felix-hilden felix-hilden self-assigned this May 7, 2020
@felix-hilden felix-hilden force-pushed the version-2 branch 5 times, most recently from d08097f to 208ccc2 Compare May 9, 2020 08:22
@felix-hilden
Copy link
Owner Author

felix-hilden commented May 17, 2020

@marioortizmanero I would really appreciate if you had a quick look at these changes, just to get a second opinion on our general direction. A full code review is a bit much to ask, but looking at the linked issues, release notes, and even the documentation provides a good overview.

Also, I think we'll go with Requests+HTTPX for now. It seems to be working alright.

@felix-hilden
Copy link
Owner Author

Would you be willing to do it, @marioortizmanero? If not, say, during this week, then I'll merge these changes and make a release soon.

@felix-hilden felix-hilden merged commit 6b6aa79 into master May 21, 2020
@felix-hilden felix-hilden deleted the version-2 branch May 21, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Change behaviour of an existing component enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant