New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tekore version 2.0 #176
Tekore version 2.0 #176
Conversation
d08097f
to
208ccc2
Compare
@marioortizmanero I would really appreciate if you had a quick look at these changes, just to get a second opinion on our general direction. A full code review is a bit much to ask, but looking at the linked issues, release notes, and even the documentation provides a good overview. Also, I think we'll go with Requests+HTTPX for now. It seems to be working alright. |
Would you be willing to do it, @marioortizmanero? If not, say, during this week, then I'll merge these changes and make a release soon. |
This pull request will introduce the next iteration of Tekore. As such, it contains a fair amount of breaking changes.
Use HTTPX exclusively, sender changes #139 Drop requests in favor of HTTPXPersistentSender
We'll also finally switch test runners from the builtin
unittest
topytest
mainly for the ease of declaring asynchronous tests withpytest-asyncio
. Mocking and patching is still done withunittest
though, and we ought to consider changing that. But this is a start.