Option to add empty cells #43
Comments
sturmer
added a commit
to salemove/xlsxtream
that referenced
this issue
Mar 4, 2021
The original library skips processing of empty cells, but this behavior is not desirable for us. There is an [issue reported][1] about it and a [PR fixing it][2], but the upstream author has not acted on it. This is the reason we decided to fork the repository and patch it manually. Credit goes to the patch's author for his work. JRVS-300 [1]: felixbuenemann#43 [2]: paladinsoftware#2
sturmer
added a commit
to salemove/xlsxtream
that referenced
this issue
Mar 4, 2021
The original library skips processing of empty cells, but this behavior is not desirable for us. There is an [issue reported][1] about it and a [PR fixing it][2], but the upstream author has not acted on it. This is the reason we decided to fork the repository and patch it manually. Credit goes to the patch's author for his work. JRVS-306 [1]: felixbuenemann#43 [2]: paladinsoftware#2
|
This is expected behavior in Excel and not something that xlsxtream should try to work around imao. I'd vote for closing this isssue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello again!
I had one more issue with this gem. It's a pretty strange excel formatting behavior - if a cell with an overflowing text is next to the cell which does not exist in file it allows the text to overflow.
Example:
Adding blank cell after this one fixes the issue:
On my fork I dealt with it by just removing condition to skip empty cells:
https://github.com/paladinsoftware/xlsxtream/pull/2/files
Maybe it would be good to introduce an option like
empty_cells:which isfalseby default. I can create a PR if you think that it can be useful.The text was updated successfully, but these errors were encountered: