Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefun not listed as dependency #40

Closed
Timple opened this issue Jun 10, 2024 · 1 comment
Closed

makefun not listed as dependency #40

Timple opened this issue Jun 10, 2024 · 1 comment
Assignees
Labels
maintenance Keeping things going, getting rid of technical debt

Comments

@Timple
Copy link
Contributor

Timple commented Jun 10, 2024

If should be part of the exec_depend in the package.xml.

And an entry should be added to the rosdistro https://github.com/ros/rosdistro/blob/80576121cd588793659f626976c813dca4a9c301/rosdep/python.yaml#L6844

But since this dependency is only used for a 5 line function:

def remove_signature_parameters(s, param_names):
    """
    Removes the provided parameters from the signature `s` (returns a new `Signature` instance).

    :param s:
    :param param_names: a list of parameter names to remove
    """
    params = OrderedDict(s.parameters.items())
    for param_name in param_names:
        del params[param_name]
    return s.replace(parameters=params.values())

It might also just be rephrased here depending on preference.

@felixdivo felixdivo self-assigned this Jun 16, 2024
@felixdivo felixdivo added the maintenance Keeping things going, getting rid of technical debt label Jun 16, 2024
@felixdivo
Copy link
Owner

Jupp, that was still missing for #23. It is now done in #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keeping things going, getting rid of technical debt
Projects
None yet
Development

No branches or pull requests

2 participants