Is it possible to add this package as a rosdep dependency

[vik748]

I am wondering if it is possible to have this package be added as a <test_depend> in the package manifest. I did not find this package on the rosdep list https://github.com/ros/rosdistro/blob/master/rosdep/python.yaml.

[felixdivo]

Oh yeah, why not?! I haven't done this yet because I didn't find the time yet but also because I was unsure about the maturity of the tool. But yeah, adding it sounds reasonable. Would you mind adding it there?

[vik748]

The tool is great, it has allowed us to cleanly test our nodes. One thing that would put it over the top is support for actions.
For now I was planning to use the env node to try testing actions do you have any advise or examples?

When I get some time I will create a PR for rosdep. Cheers.

[vik748]

Started PR ros/rosdistro#39892

[felixdivo]

Excellent, thank you @vik748!

[felixdivo]

#33 is now merged.

[vik748]

Awesome thanks for putting in the work, I see how much it involved.

[felixdivo]

You're welcome. :)

Is it now sufficient to allow packaging as a ROS package? Or is it still a problem that we require makefun via pip (instead of via rosdep)? Code reference:

ros2-easy-test/ros2_easy_test/setup.py

Line 39 in 3d075d1

install_requires=["makefun>=1.15.2"],

[vik748]

I am not 100% sure but I think all the dependencies in the tree should be rosdep installable. I think we have 2 options:

1. We should be able to add makefun to rosdep, similar to how we were planning to add ros2-test-easy. Here are the instructions for that: https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md#rosdep-rules-contributions
2. I don't know exactly how you are using makefun, but maybe there is another package already in rosdep that gets you what you need.

Once we get through this step, I believe the next will be to Release it through the ROS2 buildfarm. Again, I haven't done this before, but looks like the process should be: https://docs.ros.org/en/foxy/How-To-Guides/Releasing/Releasing-a-Package.html

[felixdivo]

Well, makefun is a very specific piece of software, so I doubts it's easily replaceable. But at least, it's in the Ubuntu packages, so it is even a bit nice to do (1.) .

[felixdivo]

Makefun is not required anymore (#40 / #41).

[felixdivo]

As far as I know, nothing speaks against adding this to rosdep as-is. Contributions are welcome.

[vik748]

Agreed, excited to see this move along.

[Timple]

@felixdivo can you bump the version with a tag attached? Make sure the version in the package.xml holds the same version.

This can be used for referencing in the buildfarm.

[felixdivo]

Thanks @Timple, I'll take care of this tomorrow!