Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default style to themes which gets applied to "everything else". #61

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Conversation

mkantor
Copy link
Contributor

@mkantor mkantor commented Mar 3, 2019

The new default key in themes allows configuring the "base" style for substrings not handled by highlight.js. The specifics depend on the language but this typically includes things like commas in parameter lists, semicolons at the end of lines, etc.

For example, here's how the JSON fixture looks in my console with no styles set:

screen shot 2019-03-03 at 11 33 59 am

And here it is with default set to dim:

screen shot 2019-03-03 at 11 32 42 am

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #61 into master will increase coverage by 1.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   65.95%   67.34%   +1.38%     
==========================================
  Files           2        2              
  Lines          47       49       +2     
  Branches        5        6       +1     
==========================================
+ Hits           31       33       +2     
  Misses         16       16
Impacted Files Coverage Δ
src/theme.ts 36.36% <ø> (ø) ⬆️
src/index.ts 92.59% <100%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d352780...2279403. Read the comment docs.

@mkantor
Copy link
Contributor Author

mkantor commented Mar 21, 2019

@felixfbecker have you had a chance to look at this yet?

@felixfbecker felixfbecker merged commit 73bcf23 into felixfbecker:master Mar 22, 2019
@felixfbecker
Copy link
Owner

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants