Fix crash on unknown foreach type #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
approved these changes
Dec 24, 2017
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
============================================
- Coverage 81.55% 81.46% -0.09%
Complexity 901 901
============================================
Files 61 61
Lines 2060 2061 +1
============================================
- Hits 1680 1679 -1
- Misses 380 382 +2
|
|
Coverage went down because https://xdebug.org is down right now so Windows didn't have XDebug to generate coverage |
cgxxv
pushed a commit
to cgxxv/php-language-server
that referenced
this pull request
Mar 25, 2022
…ker#562) Fix when unknown type is found in foreach expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash when a node in a foreach expression cannot be resolved to a type.
Fixes #561