Fix infinite loop when indexing self referencing classes

[d0x2f]

As the indexer attempts to parse the parent class, it adds itself to the array being iterated.

A simple check that the FQN isn't identical resolves the issue.

fixes #669

[felixfbecker]

What about a loop like this?

class A extends B {}
class B extends A {}

[codecov]

Codecov Report

Merging #670 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #670      +/-   ##
============================================
+ Coverage     82.16%   82.19%   +0.02%     
- Complexity      921      922       +1     
============================================
  Files            44       44              
  Lines          2148     2151       +3     
============================================
+ Hits           1765     1768       +3     
  Misses          383      383

Impacted Files	Coverage Δ	Complexity Δ
src/DefinitionResolver.php	87.45% <100%> (+0.06%)	332 <0> (+1)	⬆️

[d0x2f]

indeed that causes the same looping issue.

I'm not familiar enough with the codebase to know if there's a list of already processed FQN's we can lookup.

I'll think on it.

[d0x2f]

I've added a list of visited fqns and changed the check to prevent adding a parent fqn that's already been visited.

Let me know what you think.

[felixfbecker]

🎉 This PR is included in version 5.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀