fix: Update reflection-docblock for broken handling of phpstorm-stubs and deprecated method.

.github/workflows/build.yml

@@ -0,0 +1,60 @@
+name: build
+
+on: [push, pull_request]
+
+env:
+  FORCE_COLOR: 3
+
+jobs:
+  test:
+    if: github.event_name == 'pull_request' || github.ref == 'refs/heads/main'
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        include:
+          - xdebug: xdebug-3.1.1 # renovate:keep-up-to-date
+            php: '7.4'
+            os: ubuntu-18.04
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: '14.15.3' # renovate:keep-up-to-date
+      - name: Install npm dependencies
+        run: npm ci
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          extensions: ${{ matrix.xdebug }}, ast
+          tools: composer
+      - name: Composer Install
+        run: composer install
+      - name: phpcs
+        run: ./vendor/bin/phpcs -n
+#      - name: phan
+#        run: ./vendor/bin/phan
+      - name: phpunit
+        run: vendor/bin/phpunit --coverage-clover=coverage.xml --colors=always
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v2
+#  release:
+#    runs-on: ubuntu-18.04
+#    needs: test
+#    if: github.repository_owner == 'xdebug' && github.event_name == 'push' && github.ref == 'refs/heads/main'
+#    steps:
+#      - uses: actions/checkout@v2
+#      - name: Setup Node.js
+#        uses: actions/setup-node@v2
+#        with:
+#          node-version: '14.15.3' # renovate:keep-up-to-date
+#      - name: Install npm dependencies
+#        run: npm ci
+#      - name: Build VS Code extension
+#        run: npm run build
+#      - name: Release
+#        env:
+#          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+#          VSCE_TOKEN: ${{ secrets.VSCE_TOKEN }}
+#        run: npm run semantic-release

composer.json

@@ -28,17 +28,17 @@
         "jetbrains/phpstorm-stubs": "dev-master",
         "microsoft/tolerant-php-parser": "0.0.*",
         "netresearch/jsonmapper": "^1.0",
-        "phpdocumentor/reflection-docblock": "^4.0.0",
+        "phpdocumentor/reflection-docblock": "^5.2.2",
         "psr/log": "^1.0",
         "sabre/event": "^5.0",
         "sabre/uri": "^2.0",
         "webmozart/glob": "^4.1",
         "webmozart/path-util": "^2.3"
     },
     "require-dev": {
-        "phpunit/phpunit": "^6.3",
-        "phan/phan": "1.1.4",
-        "squizlabs/php_codesniffer": "^3.1"
+        "phpunit/phpunit": "^6.5",
+        "phan/phan": "^3.2",
+        "squizlabs/php_codesniffer": "^3.6"
     },
     "autoload": {
         "psr-4": {

src/DefinitionResolver.php

@@ -1128,6 +1128,7 @@ public function getTypeFromNode($node)
             if (
                 $docBlock !== null
                 && !empty($returnTags = $docBlock->getTagsByName('return'))
+                && $returnTags[0] instanceof DocBlock\Tags\Return_
                 && $returnTags[0]->getType() !== null
             ) {
                 // Use @return tag
@@ -1354,7 +1355,7 @@ private function tryGetDocBlockTagForParameter($docBlock, $variableName)
         }
         $tags = $docBlock->getTagsByName('param');
         foreach ($tags as $tag) {
-            if ($tag->getVariableName() === \ltrim($variableName, "$")) {
+            if ($tag instanceof DocBlock\Tags\Param && $tag->getVariableName() === \ltrim($variableName, "$")) {
                 return $tag;
             }
         }

tests/Validation/cases/arrayValueShouldBeBoolean.php.expected.json

@@ -36,7 +36,7 @@
                 },
                 "containerName": "A"
             },
-            "type__tostring": "bool[]",
+            "type__tostring": "array<string,bool>",
             "type": {},
             "declarationLine": "protected $foo;",
             "documentation": null,

tests/Validation/cases/magicConsts.php.expected.json

@@ -40,7 +40,7 @@
                 },
                 "containerName": "A"
             },
-            "type__tostring": "bool[]",
+            "type__tostring": "array<\\__CLASS__,bool>",
             "type": {},
             "declarationLine": "private static $deprecationsTriggered;",
             "documentation": null,