fixed "header" event

lib/middleware/compress.js

@@ -77,12 +77,12 @@ module.exports = function compress(options) {
     // proxy
 
     res.write = function(chunk, encoding){
-      if (!res.headerSent) this._implicitHeader();
+      if (!this.headerSent) this._implicitHeader();
       return stream.write(chunk, encoding);
     };
 
     res.end = function(chunk, encoding){
-      if (!res.headerSent) this._implicitHeader();
+      if (!this.headerSent) this._implicitHeader();
       if (chunk) this.write(chunk, encoding);
       return stream.end();
     };

lib/patch.js

@@ -10,15 +10,10 @@
  */
 
 var http = require('http')
-  , res = http.OutgoingMessage.prototype;
-
-// original setHeader()
-
-var setHeader = res.setHeader;
-
-// original _renderHeaders()
-
-var _renderHeaders = res._renderHeaders;
+  , res = http.ServerResponse.prototype
+  , setHeader = res.setHeader
+  , _renderHeaders = res._renderHeaders
+  , writeHead = res.writeHead;
 
 // apply only once
 
@@ -73,4 +68,9 @@ res._renderHeaders = function(){
   return _renderHeaders.call(this);
 };
 
+res.writeHead = function(){
+  this.emit('header');
+  return writeHead.apply(this, arguments);
+};
+
 res._hasConnectPatch = true;

lib/proto.js

@@ -102,8 +102,7 @@ app.use = function(route, fn){
  */
 
 app.handle = function(req, res, out) {
-  var writeHead = res.writeHead
-    , stack = this.stack
+  var stack = this.stack
     , removed = ''
     , index = 0;
 

test/mocha.opts

@@ -0,0 +1,2 @@
+--require should
+--growl

test/patch.js

@@ -0,0 +1,86 @@
+
+var connect = require('../');
+
+describe('patch', function(){
+  describe('"header" event', function(){
+    describe('with .setHeader()', function(){
+      it('should be emitted', function(done){
+        var app = connect();
+
+        app.use(function(req, res, next){
+          res.on('header', function(){
+            res.setHeader('bar', 'baz');
+          });
+
+          next();
+        });
+
+        app.use(function(req, res){
+          res.setHeader('foo', 'bar');
+          res.end();
+        })
+
+        app.request()
+        .get('/')
+        .end(function(res){
+          res.should.have.header('foo', 'bar');
+          res.should.have.header('bar', 'baz');
+          done();
+        });
+      })
+    })
+
+    describe('with .writeHead()', function(){
+      it('should be emitted', function(done){
+        var app = connect();
+
+        app.use(function(req, res, next){
+          res.on('header', function(){
+            res.setHeader('bar', 'baz');
+          });
+
+          next();
+        });
+
+        app.use(function(req, res){
+          res.writeHead(200, { foo: 'bar' });
+          res.end();
+        })
+
+        app.request()
+        .get('/')
+        .end(function(res){
+          res.should.have.header('foo', 'bar');
+          res.should.have.header('bar', 'baz');
+          done();
+        });
+      })
+    })
+
+    describe('with .end() only', function(){
+      it('should be emitted', function(done){
+        var app = connect();
+
+        app.use(function(req, res, next){
+          res.on('header', function(){
+            res.setHeader('bar', 'baz');
+          });
+
+          next();
+        });
+
+        app.use(function(req, res){
+          res.end();
+        })
+
+        app.request()
+        .get('/')
+        .end(function(res){
+          res.should.have.header('bar', 'baz');
+          done();
+        });
+      })
+    })
+
+  })
+})

test/responseTime.js

@@ -7,7 +7,6 @@ app.use(connect.responseTime());
 
 app.use(function(req, res){
   setTimeout(function(){
-    res.setHeader('foo', 'bar');
     res.end();
   }, 30);
 });