implements compact and options{compact:true} #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
bkw
added a commit
that referenced
this pull request
Oct 16, 2012
implements compact and options{compact:true}
| if (this.offset < 1) { | ||
| return; | ||
| } | ||
| this._buffer = this._buffer.slice(this._offset); |
There was a problem hiding this comment.
Nitpick: I <3 vertical whitespace. IMO there should be an empty line above this one.
There was a problem hiding this comment.
and right you are, sir!
|
Patch LGTM.
I think that we need that benchmark - these JS VM's are magic 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@felixge: care to comment on this?
I decided only to compact on buffer-reusing writes for now. Compacting on every read felt excessive, but then again, slice() is very efficient. What do you think?