Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone abbrevs #165

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Timezone abbrevs #165

merged 2 commits into from
Sep 10, 2021

Conversation

milohax
Copy link
Contributor

@milohax milohax commented Sep 6, 2021

For #104

milohax and others added 2 commits September 6, 2021 20:45
Should fix the merge conflict, but not tested
@mikegreiling
Copy link
Contributor

@chase-manning looks like this should be good to go! 🎉

@chase-manning chase-manning merged commit ba70f31 into felixge:master Sep 10, 2021
@mikegreiling
Copy link
Contributor

Thank you so much for merging this @chase-manning 🙇‍♂️

Any chance we could get a new release of node-dateformat with these changes?

@mikegreiling
Copy link
Contributor

I have checked master out at this commit and tested it locally only to find that not only does this not fix the timezone abbreviations issue, it breaks the fallback GMT+xxxx formatting as well 😬

I'm working on a pull request to fix this, along with some tests. I'll link it here when available.

@mikegreiling
Copy link
Contributor

@chase-manning I've opened #166 to fix the issues introduced here. Sorry for not being more thorough in my assessment the first time around 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants