Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust filename regex to allow filenames with semicolons #58

Closed
wants to merge 1 commit into from
Closed

Conversation

abram
Copy link

@abram abram commented Apr 13, 2011

Hi,

This little change tweaks the filename-matching regex to allow for filenames with semicolons. Currently the presence of a semicolon in the file name makes the filename regex not match, so part.filename doesn't get set, which makes the test in incoming_form line 147 return false, so it applies the maxFieldsSize check. I noticed this because my server was throwing an error when trying to upload a large podcast file.

Thanks for the nice library, it's been very helpful for my app Listening Room (http://listeningroom.net).

@felixge
Copy link
Collaborator

felixge commented Apr 13, 2011

Hi, I won't be able to merge this right away as this breaks an existing test showing an upload issue with quotes in filenames in IE. I'll look for a proper solution in the parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants