generic_string: handle empty strings correctly

felixguendling · May 13, 2024 · 62bd0e7 · 62bd0e7
1 parent ad3b014
commit 62bd0e7
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/include/cista/containers/string.h b/include/cista/containers/string.h
@@ -349,8 +349,11 @@ struct generic_string {
     if (size_s > size()) {
       return false;
     }
+    if (size_s == 0) {
+      return true;
+    }
     if (empty()) {
-      return size_s == 0;
+      return false;
     }
     return !std::memcmp(s, data(), size_s);
   }
@@ -374,8 +377,11 @@ struct generic_string {
     if (size_s > size()) {
       return false;
     }
+    if (size_s == 0) {
+      return true;
+    }
     if (empty()) {
-      return size_s == 0;
+      return false;
     }
     return !std::memcmp(s, data() + size() - size_s, size_s);
   }