Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic_unique_ptr: reset on move assignment #176

Merged
merged 1 commit into from
Feb 22, 2023
Merged

basic_unique_ptr: reset on move assignment #176

merged 1 commit into from
Feb 22, 2023

Conversation

AdelKS
Copy link
Contributor

@AdelKS AdelKS commented Feb 22, 2023

Hello!

While I was running asan and tsan tests on my project, I met a memory leak. It took me a while, but I found the culprit ! I think cista definitely needs to have its tests run with the address sanitizer.

Now that I think about it: maybe it's worth specialising std::swap for cista's classes.

Adel

otherwise the previously held value is leaked
@felixguendling felixguendling merged commit 6ab3056 into felixguendling:master Feb 22, 2023
@felixguendling
Copy link
Owner

The CI tests run already with -fsanitizer=address,undefined. The problem in this case is test coverage. I'm open to merge PRs that increase test coverage (or std::swap specializations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants