New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hapi auth "modes" #14
Conversation
@marttinen thx for the PR. can you pls fix the linting error? :) |
Sure, not done yet. :) |
Please note that on requests with invalid authentication, the result changed from
to
I'm not sure why the order changed, but IMO that shouldn't be an issue. |
@@ -27,21 +27,11 @@ test('get boom error with custom scheme', (t) => { | |||
})) | |||
}) | |||
|
|||
test('get boom error with default message', (t) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed because duplicated test.
It's because it depends if the so you're finished and happy with the result? ;-) |
Yep, work finished and ready to be merged. |
Added tests to check hapi's
mode: 'optional'
andmode: 'try'
.